From: Amin Bandali <bandali@gnu.org>
Date: Tue, 14 Apr 2020 04:41:38 +0000 (-0400)
Subject: Resolve some byte-compiler warnings, use new ERC buffer switching functions
X-Git-Url: https://git.shemshak.org/~bandali/configs/commitdiff_plain/5361eed6d248cc54103b3992d8fdb68a829d4a0b?hp=fc9a59fbd64df571c8985d8996fb77a300eec016

Resolve some byte-compiler warnings, use new ERC buffer switching functions

* lisp/bandali-erc.el: Sprinkle a few `declare-function's here and
there, and use brand new functions `erc-switch-to-buffer-other-window'
and `erc-track-switch-buffer-other-window' I just added to emacs-27 in
38f7538d8f62ee287e8271d048f1230d840c11a0 and
13301d4266d26882f9fe7efe3046accd315d7c55 of emacs.git respectively.
---

diff --git a/lisp/bandali-erc.el b/lisp/bandali-erc.el
index 2d6f496..bc82bc6 100644
--- a/lisp/bandali-erc.el
+++ b/lisp/bandali-erc.el
@@ -1,7 +1,5 @@
 (use-package erc
-  :bind (("C-c b b" . erc-switch-to-buffer)
-         :map erc-mode-map
-         ("M-a" . erc-track-switch-buffer))
+  :bind ("C-c w e" . erc-switch-to-buffer-other-window)
   :custom
   (erc-join-buffer 'bury)
   (erc-lurker-hide-list '("JOIN" "PART" "QUIT"))
@@ -11,12 +9,17 @@
   (erc-server-reconnect-attempts 5)
   (erc-server-reconnect-timeout 3)
   :config
+  (declare-function erc-message "erc-backend"
+                    (message-command line &optional force))
+  (declare-function erc-default-target "erc")
+  (declare-function erc-current-nick "erc")
   (defun erc-cmd-OPME ()
     "Request chanserv to op me."
     (erc-message "PRIVMSG"
                  (format "chanserv op %s %s"
                          (erc-default-target)
                          (erc-current-nick)) nil))
+  (declare-function erc-cmd-DEOP "erc" (&rest people))
   (defun erc-cmd-DEOPME ()
     "Deop myself from current channel."
     (erc-cmd-DEOP (format "%s" (erc-current-nick))))
@@ -25,6 +28,7 @@
   (add-to-list 'erc-modules 'smiley)
   (add-to-list 'erc-modules 'spelling)
   (add-to-list 'erc-modules 'scrolltoplace)
+  (declare-function erc-update-modules "erc")
   (erc-update-modules))
 
 (use-package erc-fill
@@ -42,7 +46,10 @@
 (use-package erc-track
   :after erc
   :bind (("C-c a e t d" . erc-track-disable)
-         ("C-c a e t e" . erc-track-enable))
+         ("C-c a e t e" . erc-track-enable)
+         ("C-c a e M-a" . erc-track-switch-buffer-other-window)
+         :map erc-mode-map
+         ("M-a" . erc-track-switch-buffer))
   :custom
   (erc-track-enable-keybindings nil)
   (erc-track-exclude-types '("JOIN" "MODE" "NICK" "PART" "QUIT"